This is a good deal for both sides. Poehling has been great on the forecheck for Philadelphia, even if it doesn't translate to direct points. His underlying numbers might not be too great but compared to players with similar deployment (any forward at 5v5 who has played a minimum 250 minutes within 1 standard deviation of d/zone starts / 60), Poehling is 79th best in xGF/60 and 100th best in CF/60 (out of 212 players). His PDO is 186th out of 212 best, so he stands to have some puck luck go his way.
He fits the style of play and 1.9M x 2 for someone who can PK and play hard is worth it.